Use recommended theme from theme manager #41
Conversation
|
@uhafner I have some follow up work for moving the UI to theme manager but this is more important I think. |
|
I doubt that I find spare time this and next week, sorry. |
np |
|
@uhafner I find it a really poor developer UX that |
|
Well, there is no unified warnings plugin for maven available right now (that takes into account new and outstanding warnings). |
much easier imo to either be at 0 warnings or suppress existing warnings and don't allow new ones |
|
Yes, that is what I try to do in my projects. But does CheckStyle, SpotBugs and PMD report the actual warnings in a readable way already? Then it would make sense to set the |
|
Yes readable just fine |
src/main/resources/io/jenkins/plugins/prism/SourceCodeViewModel/index.jelly
Show resolved
Hide resolved
| @@ -175,7 +182,7 @@ | |||
| <goal>copy-resources</goal> | |||
| </goals> | |||
| <configuration> | |||
| <outputDirectory>${project.build.directory}/${project.artifactId}/js</outputDirectory> | |||
| <outputDirectory>${project.basedir}/src/main/webapp/js</outputDirectory> | |||
There was a problem hiding this comment.
maven-hpi-plugin cannot find resources if they are in the build directory. They need to be in the webapp directory to be picked up.
It works on a full winstone server but not the jetty dev server.
This also breaks SNAPSHOT dependencies across different plugins, e.g. creating a SNAPSHOT of this plugin and running it in the design library did not work for me
I think there's similar issues throughout the echarts / bootstrap plugins
There was a problem hiding this comment.
This looks like a bug in the maven-hpi-plugin, can't we fix that there? Copying generated sources to the src folder violates all maven standards and degenerates the developer experience in IntelliJ.
There was a problem hiding this comment.
Unsure the impacts of changing it or if it supports multiple paths etc.
This is where the code is I believe:
https://github.com/jenkinsci/maven-hpi-plugin/blob/a041c9f3ec9675ae0ae3b56b3aa49a3c3ab7f089/src/main/java/org/jenkinsci/maven/plugins/hpi/HplMojo.java#L97-L98
degenerates the developer experience in IntelliJ.
Without this fix the developer experience doesn't work at all in IntelliJ it's 100% broken.
I assume you use that docker dev thing here without hpi:run? (that's not how plugins are normally developed though)
I assume your complaint is around generated resources showing up in search, if we can't fix maven-hpi-plugin safely then we could likely include some config in this repo to mark it as excluded.
|
Converting to draft till system theme is working |
| @@ -175,7 +182,7 @@ | |||
| <goal>copy-resources</goal> | |||
| </goals> | |||
| <configuration> | |||
| <outputDirectory>${project.build.directory}/${project.artifactId}/js</outputDirectory> | |||
| <outputDirectory>${project.basedir}/src/main/webapp/js</outputDirectory> | |||
There was a problem hiding this comment.
This looks like a bug in the maven-hpi-plugin, can't we fix that there? Copying generated sources to the src folder violates all maven standards and degenerates the developer experience in IntelliJ.
shouldn't but I plan to do more work before taking this out of draft as this approach doesn't work for system themes. |
timja
force-pushed
the
theme-manager
branch
from
6522f27 to
5a167d2
Compare
See jenkinsci/theme-manager-plugin#103
and jenkinsci/dark-theme-plugin#194
Main thing left is adapting to system themes which may need an extension to the theme manager API, I'll have a think about that tomorrow